React participant view V1 #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-bpatel
approved these changes
Jan 5, 2026
labkey-bpatel
approved these changes
Jan 5, 2026
labkey-ui-ehr/src/ParticipantHistory/TabbedReportPanel/JSReportWrapper.tsx
Outdated
Show resolved
Hide resolved
| // Declare global variables for ExtJS | ||
| declare const Ext4: any; | ||
|
|
||
| export const JSReportWrapper: FC<{ report: ReportConfig; reportNamespace?: any; tab: any }> = memo( |
Contributor
There was a problem hiding this comment.
Does it makes sense to use a concrete type instead of 'any'?
Contributor
Author
There was a problem hiding this comment.
I was able to update reportNamespace type. The others are reaching into legacy JS code so a little tougher to get definitive types.
labkey-ui-ehr/src/ParticipantHistory/TabbedReportPanel/OtherReportWrapper.tsx
Outdated
Show resolved
Hide resolved
| schemaName: report.schemaName, | ||
| reportId: report.reportId, | ||
| 'query.queryName': report.queryName, | ||
| participantId: '12345', |
Contributor
There was a problem hiding this comment.
Is the hardcoded participantId necessary?
Contributor
Author
There was a problem hiding this comment.
Thanks this was cleaned up.
labkey-ui-ehr/src/ParticipantHistory/TabbedReportPanel/OtherReportWrapper.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This is the first deliverable of a react participant view in EHR. Hidden as an experimental feature, this only applies to the participant view when clicking on an animal Id within an EHR project.
Changes